Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix an issue with data_set affecting the Validator #13224

Merged
merged 1 commit into from
Apr 21, 2016
Merged

[5.2] Fix an issue with data_set affecting the Validator #13224

merged 1 commit into from
Apr 21, 2016

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Apr 19, 2016

$data = ['companies' => 'acme'];

data_set($data, 'companies.name', 'acme');

The result is:

['companies' => 'acme']

While it should be:

['companies' => ['name' => 'acme']]

This was affecting a case with the Validator as described here #13212

For the validator's initializeAttributeOnData() to work properly it needs to overwrite the data values, so we need to use data_set() instead of data_fill().

@taylorotwell
Copy link
Member

@JosephSilber you have any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants