[5.2] Use Carbon for everything time related in DatabaseTokenRepository #13234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes timezone issues where my token had been expired for an hour already as soon as they were issued. App timezone was CET and token expiry set to 60 minutes.
annejan
changed the title
annejan
changed the title
| protected function getCurrentTime() | ||
| { | ||
| return time(); | ||
| return $expiresAt->lt(new Carbon); |
There was a problem hiding this comment.
Can you do Carbon::now() here just so the behavior is clear?
There was a problem hiding this comment.
Or maybe just $expiresAt->isPast()?
Thanks for advice @acasar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes timezone issues where my tokens had been expired for an hour already as soon as they were issued.
App timezone was CET and token expiry set to 60 minutes.