Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Improvements for Auth Guard methods loginUsingId and onceUsingId #13392

Closed
wants to merge 6 commits into from
Closed

[5.1] Improvements for Auth Guard methods loginUsingId and onceUsingId #13392

wants to merge 6 commits into from

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented May 1, 2016

Follow-up to #12999.

  • Remove redundant session set, as I explained in this message.
  • If loginUsingId didn't find user, don't try to login and return false, instead of producing a load of errors. Note how well it is consistent with onceUsingId.
  • Improve test coverage.

@GrahamCampbell
Copy link
Member

Please send to 5.2.

@vlakoff
Copy link
Contributor Author

vlakoff commented May 1, 2016

Here it is: #13393.

@vlakoff vlakoff deleted the auth-guard branch May 6, 2016 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlakoff @GrahamCampbell