[5.1] Decrement transaction count when beginTransaction errors #13551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
thanks @taylorotwell - any chance we can get a new tag on the 5.1 branch? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the transactions count is incremented before attempting the
beginTransactioncall to PDO. However, its never decremented when it fails. This is fine in most cases as the exception would bubbe up.However, when using the Job Worker Daemon, this exception is reported - but swallowed in order to keep the daemon running. That means subsequent attempts to use the Connection class from that worker cause
Can't swap PDO instance while within transaction.exceptions to be thrown.I added a couple test cases that shows that this fixes the specific issue that lead to this PR - as well as making sure existing functionality is maintained when the call succeeds.