Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Session now respects the http_only config option #13825

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

ddmills
Copy link
Contributor

@ddmills ddmills commented Jun 1, 2016

The config('session.http_only') option is not respected by the StartSession middleware. This option is useful for setting authentication cookies when running Behat tests with selenium2 and chrome driver.

In the session config file, it describes this option but never uses it:

   /*
    |--------------------------------------------------------------------------
    | HTTP Access Only
    |--------------------------------------------------------------------------
    |
    | Setting this value to true will prevent JavaScript from accessing the
    | value of the cookie and the cookie will only be accessible through
    | the HTTP protocol. You are free to modify this option if needed.
    |
    */

    'http_only' => true,

@taylorotwell taylorotwell merged commit bf05d24 into laravel:5.2 Jun 2, 2016
@vlakoff
Copy link
Contributor

vlakoff commented Jun 2, 2016

Indeed, the change has had been made to laravel/laravel (laravel/laravel#3697), but the corresponding change in laravel/framework had been overlooked (#12809). Good catch :)

@mzaalan
Copy link

mzaalan commented Jul 25, 2016

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants