Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Minor Builder cleanup #13884

Merged
merged 1 commit into from
Jun 5, 2016
Merged

[5.2] Minor Builder cleanup #13884

merged 1 commit into from
Jun 5, 2016

Conversation

acasar
Copy link
Contributor

@acasar acasar commented Jun 5, 2016 •
edited
Loading

Did some more refactoring of nestWheresForScope to make it simpler (we're always passing a single offset now). I also fixed some return annotations.

@taylorotwell taylorotwell merged commit 2341879 into laravel:5.2 Jun 5, 2016
@taylorotwell
Copy link
Member

I wonder if sliceWhereConditions can be better named? It sounds like by the name it would return something ... "slice them and return them"... but it actually modifies the query and nests conditions it seems like.

@acasar
Copy link
Contributor Author

acasar commented Jun 5, 2016

@taylor Yeah it probably should be changed... What about addWhereSliceToQuery? I can make a PR tomorrow.

@acasar acasar mentioned this pull request Jun 6, 2016
Merged
taylorotwell pushed a commit that referenced this pull request Jun 6, 2016
@acasar @taylorotwell
[5.2] Rename method (#13894)
9e7df97 
Renamed a method as discussed here #13884
symfony-splitter pushed a commit to illuminate/database that referenced this pull request Jun 6, 2016
@acasar @taylorotwell
[5.2] Rename method (#13894)
7908db8 
Renamed a method as discussed here laravel/framework#13884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acasar @taylorotwell