[5.1] BeanstalkdJob bury function delete job unexpectedly #13963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job will be deleted whenever bury job function is called.
Due to the release flag is not mark, every job goin to bury will be delete eventually.
```php
if (! $job->isDeletedOrReleased()) {
$job->delete();
}
```
GrahamCampbell
changed the title
|
Can find no indication that releasing is needed before burying. Please send link to documentation that states this is necessary. |
|
Yes. No releasing is needed, it's just a workaround so that $release set to true and the job won't be deleted. The bug is the job would never be bury, it's just deleted at last. |
|
I'm not sure releasing it is the answer then. We should solve the problem in another way. |
|
Yes. Thanks Taylor. it's affected 5.2 as well. |
|
Should we add a bury and isBuried function in Job class? But there is only beanstalkd got this bury function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job will be deleted whenever bury job function is called.
Due to the release flag is not mark, every job goin to bury will be delete eventually.