Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Confirm Ajax request is not Pjax #14024

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

dwightwatson
Copy link
Contributor

This brings the response requirements in the FormRequest into line with the ValidatesRequest trait. See issue #13997 for more information.

@barryvdh
Copy link
Contributor

And just checking the wantsJson, or is that not reliable enough?

@GrahamCampbell GrahamCampbell changed the title Confirm Ajax request is not Pjax [5.2] Confirm Ajax request is not Pjax Jun 17, 2016
@sebastiandedeyne
Copy link
Contributor

I'm actually a fan of only checking wantsJson everywhere, would make it cleaner to request html through javascript when you're not in a pjax context. Not sure if that would break existing implementations though.

@dwightwatson
Copy link
Contributor Author

I was just bringing the constraints in the FormRequest into line with the ValidatesRequest trait. I suppose there is an argument to only check wantsJson, though it would not be backwards compatible.

@taylorotwell taylorotwell merged commit acc0c96 into laravel:5.2 Jun 17, 2016
@taylorotwell
Copy link
Member

Merging this for now but do have in my notes to revisit all these types of checks where we seem to just need one method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants