Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Deal with cases when the manifest is empty #14030

Merged
merged 2 commits into from
Jun 17, 2016
Merged

[5.1] Deal with cases when the manifest is empty #14030

merged 2 commits into from
Jun 17, 2016

Conversation

GrahamCampbell
Copy link
Member

Closes #13590.

@GrahamCampbell GrahamCampbell mentioned this pull request Jun 17, 2016
Closed
@taylorotwell
Copy link
Member

So what is the behavior here? Do we not need to return a default format?

@taylorotwell
Copy link
Member

This looks broken and like it wasn't even tested on an app. Won't it immediately try to access $manifest['when']?

@GrahamCampbell
Copy link
Member Author

No, it can return null if the file doesn't exist too?

@taylorotwell taylorotwell merged commit f9ffa61 into 5.1 Jun 17, 2016
@GrahamCampbell GrahamCampbell deleted the manifest branch June 17, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @taylorotwell