[5.3] Swaps Drop for DropIfExists #15113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During development I find myself migrating up and down frequently. If an error pops up that causes the migration to fail, it often requires manual db manipulation to get the migration flow running again. DropIfExists has helped in these situations. Signed-off-by: Jesse Schutt <[email protected]>
GrahamCampbell
changed the title
|
Thanks, but I'm 👎 here. |
|
Hey @GrahamCampbell , thanks for the feedback. Would you help me understand why this is a bad idea? Thank you! |
|
@jschutt Thanks, I run into that frequently. |
|
I'd say this is bad because it silently hides mistakes and allows you to write code that doesn't actually drop the correct table by mistake. |
|
@GrahamCampbell Thanks! I can see what you are saying by it not being quite as declarative, however, in either case using |
|
Not if you have a typo in the table name though. |
|
I appreciate the explanation @GrahamCampbell 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development I find myself migrating up and down frequently. If an error pops up that causes the migration to fail, it often requires manual db manipulation to get the migration flow running again. DropIfExists has helped in these situations.
Signed-off-by: Jesse Schutt [email protected]