Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add fallback field to SlackAttachment #16912

Merged
merged 1 commit into from
Dec 22, 2016
Merged

[5.3] Add fallback field to SlackAttachment #16912

merged 1 commit into from
Dec 22, 2016

Conversation

freekmurze
Copy link
Contributor

This PR adds the fallback field to SlackAttachment.

The function of that field as explained in the Slack documentation:

A plain-text summary of the attachment. This text will be used in clients that don't show formatted text (eg. IRC, mobile notifications) and should not contain any markup.

@freekmurze freekmurze changed the title Add fallback field to SlackAttachment [5.3] Add fallback field to SlackAttachment Dec 21, 2016
@GrahamCampbell
Copy link
Member

Does Slack autogenerate one if none is provided?

@freekmurze
Copy link
Contributor Author

freekmurze commented Dec 22, 2016

In some cases Slack is unable to autogenerate it.

Consider this very compact Slack notification. Both the message and attachment have no text. In that case this is how the notification looks like in macOS:

no fallback

@taylorotwell taylorotwell merged commit c07cc7b into laravel:5.3 Dec 22, 2016
@freekmurze freekmurze deleted the feature-slack-fallback-field branch December 22, 2016 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants