[5.7] Added default array value for redis config #25443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the redis config is missing from the database configuration then there's an error due to the first argument to
Arr::pull()
beingnull
and not an array:array_key_exists() expects parameter 2 to be array, null given
Line 27 already defines a default value for the client part of the configuration so it's not actually required to have any configuration to create the instance of
RedisManager
.After this change having no Redis configuation at all will still result in an InvalidArgumentException if the Redis connection is used:
Redis connection [default] not configured.
But this is more descriptive and easier to debug than the
array_key_exists
error.