[5.7] Replace all placeholders for comparison rules (gt/gte/lt/lte) properly #25513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lacing the place holders.
…nd apply it on the other input we're comparing against.
Alymosul
changed the title
|
@themsaid can you review this? |
GrahamCampbell
changed the title
|
@taylorotwell @themsaid Will this be getting back-ported into 5.6 at all? |
|
@martinbean: Laravel 5.6 is not supported anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is explained here #25481. TLDR; The replacer method replaces the place holder with a 0 instead of the actual value that we're comparing against.