New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Attach all disk attachments and not only first one #25793

Merged

taylorotwell merged 1 commit into laravel:5.7 from mnabialek:5.7-attach-all-disk-attachments

Sep 27, 2018

Contributor

mnabialek commented Sep 26, 2018

At the moment when you attach 2 files, for example:

->attachFromStorageDisk('cdn', 'one.jpg')
->attachFromStorageDisk('cdn', 'two.jpg')

only the first one is really attached because of this return inside loop.


          Attach all disk attachments and not only first one

d618cf3

taylorotwell merged commit d618cf3 into laravel:5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet