[5.7] Fix each() on BelongsToMany relationships #25832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each()
doesn't work properly onBelongsToMany
relationships. The relationship has its ownchunk()
method (that takes care of the pivot columns and the pivot relation), but it doesn't get called. Sinceeach()
is defined in the query builder, it only calls the query builder'schunk()
method.We just have to copy the query builder's
each()
method to the relationship.#24096 fixed the same issue for
HasManyThrough
relationships.We could also put
each()
in theRelation
class and cover bothBelongsToMany
andHasManyThrough
relationships with a single method.