[5.7] Fix validate method #26417
Closed
[5.7] Fix validate method #26417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new method in the contract means that it's a breaking change and should target the 5.8 release. If this gets into the 5.7 release, any existing custom implementation of the contract will be incomplete and require changes by the developer. |
|
Regarding choice; there's nothing that forces us to choose to target 5.7. We could just target 5.8 and choose to fix the issue in the next release. Not every bug and problem needs to be fixed in the current release, specially if they have the potential to break existing applications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fix #25736, #25750.
941c8c7 cause when
Illuminate\Foundation\Http\FormRequest::validatedis called. validated again.I add contracts method. I think there is no choice to fix this problem.
I apologize...