Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport session handler fix #26456

Closed
wants to merge 6 commits into from
Closed

Conversation

web-engineer
Copy link

Following up from the pull here -

#26441

I've reverted my changes to the composer setup and just left the back-port to the database session handler.

In response to -

I'm sorry but we don't support 4.x any longer

Hoping this trivial update that would be appreciated by some as its a constant irritation for us being stuck on version 4 without the option to update.


Summary from the previous pull request -

I've back ported a fix in 5 to solve the session fixation issue.

This is the issue discussed here -
#9251 (comment)
and fixed later in laravel 5 on commit d9e0a6a

Hoping that this helps others stuck on a 4.2 codebase experiencing the problem.

This manifests itself in the laravel logs as -

local.ERROR: 500 exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'xxxxxxxxxx' for key 'sessions_id_unique'' in vendor/laravel/framework/src/Illuminate/Database/Connection.php:369

local.ERROR: 500 exception 'PDOException' with message 'SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'XXXXXXX' for key 'sessions_id_unique'' in vendor/laravel/framework/src/Illuminate/Database/Connection.php:369

laravel#9251 (comment)

Fix -

laravel@d9e0a6a
This reverts commit 7e9f128.
@driesvints
Copy link
Member

As I said before Laravel 4 is closed for maintenance. You're also still mixing tabs with spaces, etc.

@driesvints driesvints closed this Nov 9, 2018
@web-engineer
Copy link
Author

Well - i tried, thanks for your swift response, will continue from our own fork, obviously the spaces to tabs conversion is a deal breaker...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants