Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] DB seed function in testing now accept an array too #26734

Merged
merged 4 commits into from
Dec 4, 2018

Conversation

johannebert
Copy link
Contributor

This pull requests add the ability to accept an array of seed classes too.

/src/Illuminate/Foundation/Testing/Concerns/InteractsWithDatabase@seed

😀

@jmarcher
Copy link
Contributor

jmarcher commented Dec 4, 2018

I do not feel like introducing this new dependency brings many benefits. Please explain why this change is needed.

@johannebert
Copy link
Contributor Author

I do not feel like introducing this new dependency brings many benefits. Please explain why this change is needed.

Hey, in my case of testing i have many seed classes and to run them specific for particular test to really speed up the test suite.
Why should i run complete DatabaseSeeder if i only need a couple of them. And because it may be more than one seed class it would be great to run them in one function that accept also an array.

@taylorotwell taylorotwell merged commit ee01074 into laravel:5.7 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants