New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Fix loadMissing() with duplicate relation names #27040

Merged

taylorotwell merged 1 commit into laravel:5.7 from staudenmeir:load-missing

Jan 3, 2019

Contributor

staudenmeir commented Jan 3, 2019 •

edited

Loading

loadMissing() doesn't work with duplicate relationship names:

$posts = Post::with('comments')->get();
$posts->loadMissing('comments.parent.parent');
                                     ^^^^^^

This is caused by the structure of the internal $path array:

// before
array:2 [
  "comments" => "comments"
  "parent" => "parent"
]

// now
array:3 [
  0 => array:1 [
    "comments" => "comments"
  ]
  1 => array:1 [
    "parent" => "parent"
  ]
  2 => array:1 [
    "parent" => "parent"
  ]
]

Fixes #27039.


          Fix loadMissing() with duplicate relation names

f5a0560

Contributor

phh commented Jan 3, 2019

Can confirm that this fixes my issue in #27039

taylorotwell merged commit cec4317 into laravel:5.7

staudenmeir deleted the load-missing branch

January 3, 2019 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet