[5.7] Reflash the session for the broadcasting auth call. #27647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using session flash and broadcasting, the flashed message is being aged by the presence channel auth request. The BroadcastController needs the web middleware in order to authenticate the user, however while accessing the session middleware the flashed data is being aged out. Here is how the requests go:
This is unexpected behavior, and since the auth request is not supposed to touch the session flash, we need to reflash it there to avoid the session flash being aged out one request too early.
I can't think of a reasonable way to write a test for this, so if someone can suggest something I'll be happy to write it.