Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Pass email verification URL to callback #28428

Merged
merged 1 commit into from
May 7, 2019
Merged

[5.8] Pass email verification URL to callback #28428

merged 1 commit into from
May 7, 2019

Conversation

tillkruss
Copy link
Contributor

Just like the ResetPassword notification does:

framework/src/Illuminate/Auth/Notifications/ResetPassword.php

Lines 55 to 57 in 82d9910

if (static::$toMailCallback) {
return call_user_func(static::$toMailCallback, $notifiable, $this->token);
}

Not having to generate the verification URL keeps the callback simpler.

@tillkruss tillkruss changed the title ass email verification URL to callback [5.8] Pass email verification URL to callback May 6, 2019
@taylorotwell taylorotwell merged commit 506eedb into laravel:5.8 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tillkruss @driesvints @taylorotwell