[5.8] Don't check for status code in assertJsonMissingValidationErrors() #28913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28595 fixes a problem where returning an empty response causes the
assertJsonMissingValidationErrors
assertion to fail because an empty response is not valid json.This PR removes the status code 204 check. With this PR you can write tests using
assertJsonMissingValidationErrors
without explicitly returning a response. For example:Controller:
Test:
Using a combination of these two assertions is useful because if the validation fails, the test will output exactly what went wrong. It also checks if your code explodes and causes a 500 error.
Often when writing api endpoints, you don't return a response. It is either not necessary, or because the consumer should just do another index call. However, currently the test above fails because we are not explicitly returning a 204 status code.