Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Support job middleware for queued notifications #30070

Merged
merged 1 commit into from
Sep 30, 2019
Merged

[6.x] Support job middleware for queued notifications #30070

merged 1 commit into from
Sep 30, 2019

Conversation

vigneshgurusamy
Copy link
Contributor

@vigneshgurusamy vigneshgurusamy commented Sep 23, 2019

Implementation for issue #30057

@vigneshgurusamy vigneshgurusamy marked this pull request as ready for review September 23, 2019 13:02
@driesvints driesvints changed the title [6.0] Support job middleware for queued notifications [6.x] Support job middleware for queued notifications Sep 23, 2019
@taylorotwell
Copy link
Member

I wouldn't have a property at all. Just check the method.

@vigneshgurusamy
Copy link
Contributor Author

vigneshgurusamy commented Sep 24, 2019

@taylorotwell Both Job and Notification classes use Queuable trait which implements through() method to set middlewares.

If we remove the property check, we will lose the ability to set middleware via through() method.

Still, users will be able to call through() method from queued notification but middlewares won't be added to queued notification job from the property.

So how do we solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants