Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Resolve issue with tests using table() #31447

Merged
merged 4 commits into from
Feb 12, 2020
Merged

[6.x] Resolve issue with tests using table() #31447

merged 4 commits into from
Feb 12, 2020

Conversation

adam-prickett
Copy link
Contributor

As mentioned in #31445, my latest PR adding support for appendRow() when using table() in an Artisan command caused tests on commands using table() to fail due to the use of ConsoleSectionOutput

This PR attempts to resolve those issues by adding section() to the BufferedOutput mock, returning a ConsoleSectionOutput instance with a mocked stream puching back to the BufferedOutput

@GrahamCampbell GrahamCampbell changed the title Resolve issue with tests using table() [6.x] Resolve issue with tests using table() Feb 12, 2020
@taylorotwell taylorotwell merged commit 74e4f56 into laravel:6.x Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants