[6.x] Fix postgres grammar for nested json arrays

[mathieutu]

Hi,
This PR fix a bug when quering postgres json field.

I have a json details field which contains :

{"firstName": "John", "lastName": "Doe", "phones": ["+33123456789", "+44123456789"]}

With this Eloquent query:

Contact::where([
    'details->firstName' => 'John',
    'details->lastName' => 'Doe',
    'details->phones->0' => '+33123456789',
])->firstOrFail();

The builder should return the row.

The problem is that the Postgres query generated is :

"select * from "contacts" where ("details"->>'firstName' = 'John' and "details"->>'lastName' = 'Doe' and "details"->'phones'->>'0' = '+33123456789') limit 1"

which return no result, and fail.

The working query is:

"select * from "contacts" where ("details"->>'firstName' = 'John' and "details"->>'lastName' = 'Doe' and "details"->'phones'->>0 = '+33123456789') limit 1"

See the difference:

- "details"->'phones'->>'0'
+ "details"->'phones'->>0

This PR fix this issue, by omitting the quote if the attribute is a integer.

A test was added.

Thanks.
Matt'

[staudenmeir]

Please see #26415 (comment) on why this is a breaking change.

[GrahamCampbell]

Please don't use these val functions. Please use casts. They do the same.

[taylorotwell]

Ah, just saw @staudenmeir's comment. Will likely have to revert.

[taylorotwell]

@staudenmeir this seems like a slightly different situation than the issue you linked?

[mathieutu]

Actually here the Contact I would like to fetch is created with:

Contact::create([
    'details->firstName' => 'John',
    'details->lastName' => 'Doe',
    'details->phones->0' => '+33123456789',
]);

This is the behavior of Laravel (and even of php json_encode actually) to set the phones->0 to an array, instead of an object with key 0.

Also, it feels quite normal to be able to query an entity by the same arguments it was created.

Update works exactly the same.

In my opinion, not considering this as a bug and set the opposite as the default would be quite weird.

However, we can provide a way to force the understanding of the query as string, like details->phones->'0'. (And I can make the PR if it helps approving this one)