[6.x] Prevent long URLs from breaking email layouts #32189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imacrayon
force-pushed
the
message-urls
branch
2 times, most recently
from
ee3e986
to
8dba2ad
Compare
GrahamCampbell
changed the title
|
This fix should probably go into 6.x. |
|
I agree with @GrahamCampbell. |
|
👍 thanks for the fast feedback. I’ll get this branch re-targeted |
driesvints
changed the title
|
Your modifications brake the caouecs/Laravel-lang/ package because you removed the actionURL, see this issue and this PR. So we can't translate the footer content anymore. Edit: not a problem just have to update the caouecs/laravel-lang project because we don't need to translate an URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long URLs will break the default email notification layout because they don't wrap:
I added a new utility class to the default mail theme and modified the notification layout so that URLs in notifications are forced to wrap:
I'd consider this a breaking change because I had to update a translation string in the notification layout.