Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Removed unnecessary checks in RequiredIf validation, fixed tests #37700

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[6.x] Removed unnecessary checks in RequiredIf validation, fixed tests #37700

merged 1 commit into from
Jun 16, 2021

Conversation

0xcrypto
Copy link
Contributor

In reference to discussion in #37688

  • This patch removes the unnecessary boolean and callable check so that null and 0 as input works as expected before.
  • Also, tests were fixed as pointed out in the older PR.

@GrahamCampbell GrahamCampbell changed the title [6.x ] Removed unnecessary checks in RequiredIf validation, fixed tests [6.x] Removed unnecessary checks in RequiredIf validation, fixed tests Jun 16, 2021
@taylorotwell taylorotwell merged commit a048f99 into laravel:6.x Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xcrypto @taylorotwell