[8.x] Adds XDEBUG_MODE and XDEBUG_CONFIG to the list of env vars that are passed on to the php web server #38228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…always passed on to the built-in php web server process.
nhaynes
changed the title
|
I got it added - sorry! |
|
Is there a way to disable it from a parameter inside .env file ? We don't need it normally because docker is extremely slow on mac. It looks like having those won't work: SAIL_XDEBUG_MODE=off |
@mirzazeyrek Are you using Laravel Sail? The XDEBUG_MODE env var in sail is defaulted to off for this. See laravel/sail#209 |
|
By default it's enabled for the web requests (phpinfo page) and console
requests like sail php - v.
Those off mode does not seemed to be working by default.
…On Fri, 13 Aug 2021, 00:59 Nick Haynes, ***@***.***> wrote:
Is there a way to disable it from a parameter inside .env file ? We don't
need it normally because docker is extremely slow on mac.
It looks like having those won't work:
SAIL_XDEBUG_MODE=off
XDEBUG_MODE=off
@mirzazeyrek <https://github.com/mirzazeyrek> Are you using Laravel Sail?
The XDEBUG_MODE env var in sail is defaulted to off for this. See
laravel/sail#209 <laravel/sail#209>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38228 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPR4MTAR64PETNGX4GYPQTT4RG5XANCNFSM5BO6BETQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation for #38211
This is needed for when using a .env file but still need to provide environment variables to PHP or a PHP extension such as xdebug.
Currently, Laravel Sail won't work with xdebug if you provide the configuration thru the XDEBUG_MODE and XDEBUG_CONFIG environment variables because this command doesn't pass the variables onto the php web server. You are forced to provide the xdebug configuration in the php.ini file but that isn't convenient for being able to turn xdebug on/off and switch between modes.