-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] Remove deprecated dates property #42587
Conversation
I know this is a good thing. Sorry if I posted in the wrong place, but the dates property is very useful. Without the |
@ghoshriju33 what do you mean? why do you need to define an accessor? |
Sorry for posting on an old PR, but was this deprecation announced anywhere? I checked upgrade guide and release notes for 7.x and later and none seem to mention it was being deprecated - only it being suddenly removed in 10.x. |
@driesvints I mean the announcement for deprecation, the time people are supposed to update their code ahead of time so it'll continue running fine after being removed in 10.x (also avoids adding new deprecated code and reduces task required for upgrading). |
The |
Annotation that isn't visible anywhere isn't really useful. It also doesn't help the update guide is only given on removal instead of deprecation (although for this one it's pretty simple). |
Agreed with @nanaya. Deprecations should be noted in the next Upgrade Guides: X-thing is deprecated and will be deleted in future releases, use Y-thing instead. Not everybody monitors GitHub Pull Requests and laravel/framework source code. Unless it's hard to maintain. |
This change makes the annotation on For anyone else looking for a quick-and-ugly hack to get back to the previous behavior, this worked for me as a short term solution until i can remove references to getDates entirely:
|
It's been over two years since the dates property became deprecated and even longer since the introduction of casts. I feel it's time to remove this property so people can solely rely on the model casts for any datetime attributes.