[10.x] File failed job storage driver #47007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
changed the title
nunomaduro
requested changes
May 10, 2023
There was a problem hiding this comment.
Looks good to me! Just added a few tests, that can be found in this pull request: #47013.
nunomaduro
approved these changes
May 10, 2023
milwad-dev
pushed a commit
to milwad-dev/framework
that referenced
this pull request
May 12, 2023
* first pass at file based failed jobs * code cleaning * use path verbatim * use default value for path * Adds tests for `FileFailedJobProvider` (laravel#47013) * add limit option to file failed job provider * fix order in test * change default location --------- Co-authored-by: Nuno Maduro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple, file-based failed job storage driver for local development and exploration when first installing the framework.
Not intended for production usage.