New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix Collection::search and LazyCollection::search return type #48030

Merged

taylorotwell merged 1 commit into laravel:10.x from bastien-phi:search_return_type

Aug 11, 2023

Contributor

bastien-phi commented Aug 11, 2023

Collection::searchand LazyCollection::search do not return trueso the return type should be TKey|false.

I did not change return type for Illuminate\Support\Enumerable::search but this could be done.

If this is considered as a breaking change, let me know and I can send this PR to master.


          Collection::search does not return true

48213b4

taylorotwell merged commit 7ee6d0d into laravel:10.x

20 checks passed

bastien-phi deleted the search_return_type branch

August 11, 2023 14:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet