[11.x] Fixed pop on default Beankstalkd queue when not specifically added #51759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know why this happens on 11? I don't remember any changes here moving from 10 to 11. |
|
Probably because laravel 10 use the "watchOnly" method https://github.com/laravel/framework/blob/10.x/src/Illuminate/Queue/BeanstalkdQueue.php#L168 instead laravel 11 is using a new version of beanstalkd library and it is not currently available this method |
|
Looks like tests are failing here. |
|
Please mark as ready for review when tests are fixed. 👍 |
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
changed the title
crynobone
changed the title
|
Fixed tests, should be ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a change in behavior observed when migrating from Laravel 10 to Laravel 11. The pop method in the queue implementation has been enhanced to ensure that it only watches the specified queue and ignores any previously watched queues, effectively restoring the behavior from Laravel 10.
Problem Statement
In Laravel 11, when launching a worker on a specific queue using the artisan command php artisan queue:work --queue=one, the worker listens to both the specified queue (one) and the default queue of Beanstalkd. This results in the worker popping jobs from both queues, which can lead to unintended job processing and potential job loss from queues meant to be handled by separate workers.