[11.x] Bugfix for calling pluck() on chaperoned relations. #52680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This test should fail if non-models are passed to `applyInverseRelationToCollection()`, e.g. when `pluck()` is called on a query.
samlev
force-pushed
the
bugfix/11.x_52660_chaperone-pluck
branch
from
9cfaa9f
to
47596a1
Compare
|
@driesvints this one was pretty small, so not a big deal to push it up now. I didn't explicitly test I'm not sure what those test failures are about - they're nothing to do with what this PR touched. The infinite recursion on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #52660 discovered an issue where calling
$model->relationship()->pluck('foo')would fail on chaperoned relations, as thepluck()method sends only the selected field to theafterQuery()callback instead of the model.This PR includes a failing test case, and a commit which resolves the issue by only attempting to hydrate the relationship on models in the callback, and skipping anything that's not a model.