[11.x] Fix handling empty values passed to enum_value() function instead of only empty string
#53181
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only empty string fixes #53180 Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
changed the title
enum_value() function instead of only empty stringenum_value() function instead of only empty string
Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
@crynobone Do you believe it will fix 11.27 11.28 |
|
@devajmeireles did you check the tests in this PR? Feel free to add more if you see it missing anything |
I'm so sorry! I didn't see the |
|
This is still broken when an empty collection is passed into Js::from(Collection::make()); // nullThis is specifically affecting eloquent query results for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53180