Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Give new app instance to cache manager #667

Merged
merged 2 commits into from
Mar 27, 2023
Merged

[1.x] Give new app instance to cache manager #667

merged 2 commits into from
Mar 27, 2023

Conversation

smortexa
Copy link
Contributor

@smortexa smortexa mentioned this pull request Mar 25, 2023
Merged
@smortexa smortexa marked this pull request as ready for review March 25, 2023 16:57
@smortexa smortexa marked this pull request as draft March 25, 2023 17:05
axlon
axlon reviewed Mar 26, 2023
View reviewed changes
Copy link

@axlon axlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smortexa you should add a method_exists() check, because octane supports Laravel 8, 9 and versions of 10 that don't have the method you added.

@smortexa smortexa marked this pull request as ready for review March 26, 2023 11:02
@taylorotwell taylorotwell merged commit 61d7c81 into laravel:1.x Mar 27, 2023
@smortexa smortexa deleted the fix/cache_manager branch March 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlon axlon axlon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smortexa @axlon @taylorotwell