Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically disable worker mode in local environments if workers aren't specified explicitly #932

Draft
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Commits on Jul 24, 2024

  1. Automatically disable worker mode in local environments if workers ar…

    …en't specified explicitly
    Radiergummi committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    86ca234 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Added check for XDebug mode as an additional requirement to enable Fr…

    …ankenPHP worker mode to avoid performance issues.
    
    See the discussion with Kévin Dunglas in the PR discussion for the reasoning: laravel#932
    
    Essentially, disabling worker mode comes with performance drawbacks, but it's still the only sensible way to use FrankenPHP with XDebug.
    By automatically turning off worker mode if
     a) the amount of workers isn't set explicitly,
     b) we're running locally, and
     c) XDebug is not installed, or it's mode is set to "off",
    we get both optimal performance and XDebug working out of the box.
    Radiergummi committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4944d1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3236ae3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74871da View commit details
    Browse the repository at this point in the history