-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update PHPDoc of issueToken #1468
Conversation
withErrorHandling() can throw an OAuthServerException - issueToken should declare this via PHPDoc
seriously? changing PHPDoc causes tests to fail ...... I'll have a look .... |
master fails as well .... |
This is likely due to a change in OAuth 2 server in the way we handle invalid passwords. Bit busy just now but should be able to take a look in an hour or so |
The last successful ci run in here used 8.2.4 - this run used 8.3.2 ... |
PR #1469 fixes the issues you are seeing with tests |
I don't see any exceptions thrown in this method. |
In trait HandlesOAuthErrors the method withErrorHandling() is for sure throwing this exception. Please check it's implementation and phpdoc. THX |
|
withErrorHandling() can throw an OAuthServerException - issueToken should declare this via PHPDoc