Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update PHPDoc of issueToken #1468

Closed
wants to merge 1 commit into from
Closed

chore: update PHPDoc of issueToken #1468

wants to merge 1 commit into from

Conversation

DeepDiver1975
Copy link

@DeepDiver1975 DeepDiver1975 commented Jul 27, 2021 •
edited by taylorotwell
Loading

withErrorHandling() can throw an OAuthServerException - issueToken should declare this via PHPDoc

@DeepDiver1975
chore: update PHPDoc of issueToken
e66caa4 
withErrorHandling() can throw an OAuthServerException - issueToken should declare this via PHPDoc
@DeepDiver1975
Copy link
Author

seriously? changing PHPDoc causes tests to fail ...... I'll have a look ....

@DeepDiver1975 DeepDiver1975 marked this pull request as draft July 27, 2021 20:39
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review July 27, 2021 20:47
@DeepDiver1975
Copy link
Author

seriously? changing PHPDoc causes tests to fail ...... I'll have a look ....

master fails as well ....

@Sephster
Copy link
Contributor

This is likely due to a change in OAuth 2 server in the way we handle invalid passwords. Bit busy just now but should be able to take a look in an hour or so

@DeepDiver1975
Copy link
Author

This is likely due to a change in OAuth 2 server in the way we handle invalid passwords.

The last successful ci run in here used 8.2.4 - this run used 8.3.2 ...
here is the diff - thephpleague/oauth2-server@8.2.4...8.3.2

@Sephster
Copy link
Contributor

PR #1469 fixes the issues you are seeing with tests

@taylorotwell
Copy link
Member

I don't see any exceptions thrown in this method.

@DeepDiver1975
Copy link
Author

In trait HandlesOAuthErrors the method withErrorHandling() is for sure throwing this exception. Please check it's implementation and phpdoc. THX

@DeepDiver1975
Copy link
Author

In trait HandlesOAuthErrors the method withErrorHandling() is for sure throwing this exception. Please check it's implementation and phpdoc. THX

@taylorotwell

@DeepDiver1975
Copy link
Author

👋 @taylorotwell

@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @Sephster @taylorotwell