[1.x] Respect configuration changes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #80
Pennant's
DatabaseDriverdoes not currently respect changes to configuration. It also holds onto aIlluminate\Database\Connectioninstance. This is problematic in Octane, queue worker, and testsuite scenarios.This PR ensures that changes to configuration, such as
Config::set('pennant.stores.database.connection', 'foo'), are respected. This most likely happens in testsuites when running in parallel.It also stops the
DatabaseDriverfrom holding on to a DB connection instance. The database manager is now injected and the connection is always resolved fresh.This is technically a breaking change for anyone extending the
DatabaseDriveras the__constructsignature has changed and the injected$dbtype has changed. I think the likelihood of extending that is pretty slim and this is a worthwhile break to fix the bug.