Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.x] Add multiple additional fixers #10

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[0.x] Add multiple additional fixers #10

merged 1 commit into from
Jun 23, 2022

Conversation

Prior to Pint existing, I used to maintain my own PHP-CS-Fixers file specific to Laravel, in which most of Pint's fixers were already included (see Laravel Forge's main repo). Some of those fixers however seem to be missing / absent, so I figured I'd PR them.
@nunomaduro nunomaduro changed the title Add multiple additional fixers [0.x] Add multiple additional fixers Jun 22, 2022
@mreduar
Copy link

mreduar commented Jun 22, 2022

Awesome!

@jasonmccreary
Copy link
Contributor

jasonmccreary commented Jun 22, 2022

@nunomaduro, these are all additive. Most align with PSR-12, which I believe Laravel follows as a base.

The others, like no_alias_language_construct_call, Laravel may happen to follow. But it's up to you if that's "official" or not. Obviously none of these are enforced by Shift's Laravel code style ruleset.

@claudiodekker
Copy link
Contributor Author

claudiodekker commented Jun 22, 2022

@jasonmccreary It doesn't seem like PSR-12 is used as a base when when using this preset, though?

@jasonmccreary
Copy link
Contributor

jasonmccreary commented Jun 22, 2022

@claudiodekker, I meant that Laravel's rules (and some of those you added) is a superset of PSR-12. Not that the code uses the @PSR12 ruleset directly.

@nunomaduro nunomaduro merged commit 5c22b7d into laravel:main Jun 23, 2022
@claudiodekker claudiodekker deleted the patch-1 branch June 23, 2022 07:37
ablancobarreda added a commit to ablancobarreda/pint that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants