[ BugFix ] Handle Failed Terminal Read Gracefully (#164)

* tell phpunit to fail on E_WARNING

* add test

* check for empty string in TypedValue listener

* strengthen types

* continue loop is key is empty string

phpunit.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true" backupStaticProperties="true">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true" backupStaticProperties="true" failOnWarning="true">
   <testsuites>
     <testsuite name="Test Suite">
       <directory suffix="Test.php">./tests</directory>

src/Concerns/TypedValue.php

@@ -27,8 +27,10 @@ protected function trackTypedValue(string $default = '', bool $submit = true, ?c
             $this->cursorPosition = mb_strlen($this->typedValue);
         }
 
-        $this->on('key', function ($key) use ($submit, $ignore, $allowNewLine) {
-            if ($key[0] === "\e" || in_array($key, [Key::CTRL_B, Key::CTRL_F, Key::CTRL_A, Key::CTRL_E])) {
+        $this->on('key', function (string $key) use ($submit, $ignore, $allowNewLine): void {
+            if ($key !== '' &&
+                ($key[0] === "\e" || in_array($key, [Key::CTRL_B, Key::CTRL_F, Key::CTRL_A, Key::CTRL_E]))
+            ) {
                 if ($ignore !== null && $ignore($key)) {
                     return;
                 }

src/Prompt.php

@@ -167,6 +167,15 @@ public function prompt(): mixed
     public function runLoop(callable $callable): mixed
     {
         while (($key = static::terminal()->read()) !== null) {
+            /**
+             * If $key is an empty string, Terminal::read
+             * has failed. We can continue to the next
+             * iteration of the loop, and try again.
+             */
+            if ($key === '') {
+                continue;
+            }
+
             $result = $callable($key);
 
             if ($result instanceof Result) {

tests/Feature/TextPromptTest.php

@@ -159,3 +159,11 @@
 
     text('What is your name?');
 })->throws(Exception::class, 'Cancelled.');
+
+it('handles a failed terminal read gracefully', function () {
+    Prompt::fake(['', Key::ENTER]);
+
+    $result = text('What is your name?');
+
+    expect($result)->toBe('');
+});