Fix required validation on suggest prompt
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where validation occurs prematurely in the
suggestprompt when the user selects one of the suggested values. This is most obvious when thesuggestprompt is marked asrequiredand the user selects a suggested value without typing anything to narrow the suggestions.This is because there are two listeners for the "Enter" key - one in the
SuggestPromptclass that sets the selected value if one has been highlighted and one in theTypedValuetrait that submits the entered or selected value. This PR solves this by registering the "suggest-specific" key listeners first.An alternative approach would be to pass the
submit: falseargument to thetrackTypedValuemethod and handle the submit behaviour directly inSuggestPromptinstead.Fixes #21