Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emacs style key binding #67

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

storyn26383
Copy link
Contributor

With this PR, we can use CTRL_P, CTRL_F CTRL_N, CTRL_B and CTRL_H to do UP, RIGHT, DOWN, LEFT and BACKSPACE.

(CTRL_P, CTRL_F, CTRL_N, CTRL_B, CTRL_H)
Copy link
Member

@jessarcher jessarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Makes me wonder whether we should add some readline keys like CTRL_A and CTRL_E, as well as Home and End. They'd probably need to work differently depending on whether you're currently focused on a list or a typed input. Someone can PR that separately if you don't feel like it belongs here though.

src/MultiSelectPrompt.php Outdated Show resolved Hide resolved
src/SelectPrompt.php Outdated Show resolved Hide resolved
@storyn26383
Copy link
Contributor Author

Good idea!
We can add home and end feature in next RP 🎉

@taylorotwell taylorotwell marked this pull request as draft September 13, 2023 18:05
@taylorotwell taylorotwell marked this pull request as ready for review September 13, 2023 23:58
@taylorotwell taylorotwell merged commit 532dd02 into laravel:main Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants