Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apt-key for WSL #389

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix apt-key for WSL #389

merged 1 commit into from
Apr 27, 2022

Conversation

Evertt
Copy link
Contributor

@Evertt Evertt commented Apr 27, 2022

This fixes #387 for me.

@driesvints closed that issue, saying that it was just a network hiccup implying it will happen sometimes, but then if you'd try again it may just work the next time.

However, I tried many many times to rerun the build process and I got the same error message every single time. Then I applied the changes suggested in this comment and after that the build process ran perfectly, immediately.

So I do believe we need these changes to make the build process more reliable. At least for an M1 Mac apparently.

So please merge this in. 🙏

Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I feel like we should give this a go at least. Hopefully it'll be the end of those key issues.

@taylorotwell taylorotwell merged commit 453c66f into laravel:1.x Apr 27, 2022
@flexchar
Copy link

This was present across any machine independent to the manufacturer. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error building the 'laravel.test' docker image on M1 mac
4 participants