[1.x] Build and pull images on install #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
commented
Aug 16, 2022
Comment on lines
-80
to
+97
| ->filter(function ($service) { | ||
| return in_array($service, ['mysql', 'pgsql', 'mariadb', 'redis', 'meilisearch', 'minio', 'selenium']); | ||
| })->map(function ($service) { | ||
| ->map(function ($service) { |
There was a problem hiding this comment.
This was missing the memcached service, but now that we're validating the services, I don't think we need to filter it.
This was referenced Aug 17, 2022
|
Hi, with Laravel framework v9.3.11 / Sail v1.16.2 , doing a "php artisan sail:install --with=none" ends up crashing because Sail tries to pull images from an empty service list. |
|
@jf-prevost thank you. Can you send in a PR? |
|
@driesvints done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
sail:installcommand so that it will download and build the required Docker images upon installation.When running
sail upon a fresh machine, it can take more than 5 minutes to download and build everything before it transitions to the serving phase. If you're unfamiliar with Docker's output, it is not immediately apparent when the downloading and building have finished and the serving has begun.While this won't decrease waiting times, it moves the "slow part" from the up command to the install command, where it's far more apparent when it has been completed. When running the up command, everything can start straight away.
Note that the database containers go through a brief "first run" setup phase where the initial user and databases are created. While users may immediately access their
laravel.testcontainer, they may briefly encounter a database connection error if they're quick enough to hit the database before it's ready.I have also added some validation to the
--withoption to ensure that we only pass sanitized data to thesail pullshell command. In doing so, I noticed that we were not adding a "depends_on" entry for memcached, which I have also resolved.Happy path
With Docker service stopped
(The output from the
sail pullandsail buildcommands is passed through to help the developer debug why the install failed, as it could be various issues such as no network)If this is merged, I will PR the docs to remove this section from https://laravel.com/docs/9.x#getting-started-on-macos, and maybe mention the time under the install command instead: