Adjust pnpm to support Sail alias #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meditto
reviewed
Sep 2, 2023
There was a problem hiding this comment.
I think it's better to put the pnpm install command on a separate line after the long-running command, like so
RUN curl -fsSL https://get.pnpm.io/install.sh | bash
this will make rebuilding faster because it allows Docker to run the long-running command from the cache
There was a problem hiding this comment.
Also, this way when you run sail shell, the pnpm command will not be available because it's installed only for the root user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to issue #606.
Adjustment to add support for pnpm when using pnpm or pnpx with the Sail alias.
Using sail
Using devcontainer/docker exec