[5.x] Revert Facebook picture access token changes #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
revert-picture-endpoint-pr
branch
from
22b8cd0
to
d43debe
Compare
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #489 which causes the
access_tokento be exposed to the outside when the picture url is directly served on a webpage. This can lead malicious third parties to make use of said access token and exploit it by making requests on behalf of the Facebook App. In light of this we've decided to revert these changes completely.Since there's no way at moment anymore to do any tokenless requests to retrieve the Facebook picture only API requests with a token can be made. These need to be built by app developers themselves from now on and hidden behind a custom route in their app in order to serve the picture in a secure fashion. It's very unfortunate that Facebook made these changes but it's out of our hands unfortunately.
I've decided to leave the
lastTokenproperty in place so it can at least still be used if needed. I've also added anlastTokenmethod to retrieve it if the app developer needs it.