Correct issue with GoogleProvider getUserByToken() method #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getUserByToken
twice from GoogleProvider will result in obtaining null value for the second call. If you directly usegetContents()
fromGuzzleHttp\Psr7\Stream
to retrieve values, after the first retrieval, you need to executeseek(0)
to reset the pointer position to the beginning. This is necessary for the second retrieval to work properly.__toString()
handles this internally.Scenario :
When using the
GuzzleHttp\Client
class, I've implemented aLogMiddleware
. This middleware is primarily for logging therequest body
andresponse body
of each API call. Consequently, during logging,getContents
is executed once, leading togetContents
during the return ofgetUserByToken
actually receiving null.