Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .valetrc #1347

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Add support for .valetrc #1347

merged 4 commits into from
Jan 19, 2023

Conversation

mattstauffer
Copy link
Collaborator

No description provided.

@mattstauffer mattstauffer changed the base branch from master to version-4 January 19, 2023 01:33
@mattstauffer mattstauffer marked this pull request as ready for review January 19, 2023 01:35
@mattstauffer
Copy link
Collaborator Author

Checks failing because of some wonky issues with GH actions, but the tests seem to pass so I'm not bothered at the moment.

@mattstauffer mattstauffer merged commit 5c7b2d3 into version-4 Jan 19, 2023
@mattstauffer mattstauffer deleted the mes/valetrc branch January 19, 2023 01:44
@mattstauffer mattstauffer mentioned this pull request Jan 19, 2023
@driesvints
Copy link
Member

Hey @mattstauffer. It might be best to retrigger the builds before merging otherwise you risk merging in failing builds meaning all PRs after it will suffer failing builds as well. If a build is failing then there's a real issue that needs to be solved (maybe not related to Valet but dependencies/tests or otherwise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants