Add —not-redirected argument to secure command #534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to still access the site via http if it is secure This touches laravel#382, laravel#148, laravel#156, laravel#504
|
is this merged? |
|
It is not. It might take a while - it currently takes the maintainers a while to get around to PR. If you need this sooner, you can either copy the changes or maintain your own fork. |
|
#630 attempts to fix this an alternate way |
This was referenced Sep 18, 2018
|
I will (try to remember to) review this once 2.1.0/2.1.1 with #630 is out. |
|
@sjelfull @nezaboravi I think the changes in the 2.1.3 release resolve this without additional code changes required. |
|
It does resolve one of the problems, in that sharing will work now out of the box. Thats really great. As a reminder, the second part of my argument: allowing anyone to opt out of the mandatory redirect would be a nice boon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the site to be available via http even if secured.
This touches #382, #148, #156, #504