Add __configure__ function to component #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamHillier
reviewed
Dec 10, 2020
Co-authored-by: Adam Hillier <[email protected]>
Co-authored-by: Adam Hillier <[email protected]>
Co-authored-by: Adam Hillier <[email protected]>
Co-authored-by: Adam Hillier <[email protected]>
|
Unfortunately some doc formatting has snuck into this PR, but only in these two files. I'll make another one that formats everything once this is merged (to prevent conflicts) |
jneeven
added
feature
…nstance' instead of 'self'
|
I've just pushed a commit to this branch that undoes the docstring formatting. That can be part of another PR if necessary. |
AdamHillier
reviewed
Dec 10, 2020
AdamHillier
reviewed
Dec 10, 2020
|
This is good to go after those small nits are dealt with :) |
Co-authored-by: Adam Hillier <[email protected]>
lgeiger
approved these changes
Dec 18, 2020
Co-authored-by: Lukas Geiger <[email protected]>
Co-authored-by: Lukas Geiger <[email protected]>
Co-authored-by: Lukas Geiger <[email protected]>
jneeven
added
feature
Closed
lgeiger
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is responsible for calling 'configure' on itself. Allows the user to override default values, change the config dict, etc.